Re: [PR] HBASE-29226 Migrate to jetty 12 with EE8 and bump java servlet to 4.0.1 [hbase]

["NihalJain (via GitHub)" <gi...@apache.org>]

NihalJain commented on code in PR #6783:
URL: https://github.com/apache/hbase/pull/6783#discussion_r2022189918


##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -758,7 +755,9 @@ protected void addDefaultApps(ContextHandlerCollection parent, final String appD
     if (logDir != null) {
       ServletContextHandler logContext = new ServletContextHandler(parent, "/logs");
       logContext.addServlet(AdminAuthorizedServlet.class, "/*");
-      logContext.setResourceBase(logDir);
+      // We are doing this as otherwise jetty 12 is not handling /dir0/dir1/../dir2
+      String logDirCanonical = Paths.get(logDir).toFile().getCanonicalPath();
+      logContext.setResourceBase(logDirCanonical);

Review Comment:
   Yes let me try to write a minimal jetty server w/o hbase and submit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org