You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/04/14 12:10:06 UTC

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1236: apps/btshell: Add scan filtering based on device name

sjanc opened a new pull request, #1236:
URL: https://github.com/apache/mynewt-nimble/pull/1236

   This allows to specify name prefix that is used to filter out devices
   when scanning. Useful in busy environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] sjanc merged pull request #1236: apps/btshell: Add scan filtering based on device name

Posted by GitBox <gi...@apache.org>.
sjanc merged PR #1236:
URL: https://github.com/apache/mynewt-nimble/pull/1236


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1236: apps/btshell: Add scan filtering based on device name

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on code in PR #1236:
URL: https://github.com/apache/mynewt-nimble/pull/1236#discussion_r850386661


##########
apps/btshell/src/btshell.h:
##########
@@ -83,10 +83,14 @@ struct btshell_conn {
     struct btshell_l2cap_coc_list coc_list;
 };
 
+#define NAME_FILTER_LEN_MAX 20
+
 struct btshell_scan_opts {
     uint16_t limit;
     uint8_t ignore_legacy:1;
     uint8_t periodic_only:1;
+    uint8_t name_filter;
+    char name[NAME_FILTER_LEN_MAX];

Review Comment:
   `name_filter` and `name_filter_len` perhaps...?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org