You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/31 01:43:05 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #10094: [C++] Reduce log level for ack-grouping tracker

BewareMyPower opened a new pull request #10094:
URL: https://github.com/apache/pulsar/pull/10094


   ### Motivation
   
   The warning log occurs when the ACK grouping tracker tries to send ACKs while the connection is closed. This case is common to see because of the current timer's design in C++ client. So the log level should be changed to debug.
   
   ### Modifications
   
   Changed the log level to debug when the connection is not ready for `AckGroupingTrackerEnabled::flush`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #10094: [C++] Reduce log level for ack-grouping tracker

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #10094:
URL: https://github.com/apache/pulsar/pull/10094#issuecomment-810755099


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10094: [C++] Reduce log level for ack-grouping tracker

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10094:
URL: https://github.com/apache/pulsar/pull/10094


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org