You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/01 00:09:54 UTC
[kudu-CR] WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12655 )
Change subject: WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
......................................................................
Patch Set 1:
> (1 comment)
It turns out this works somehow in the sense that MACOSX_DEPLOYMENT_TARGET environment variable affects the build of various components in thirdparty. For example, on macOS 10.13.6 thirdparty was building without an issue without setting this variable, but as soon as I set did 'export MACOSX_DEPLOYMENT_TARGET=10.12', an attempt to build thirdparty failed in gperftools with the following error message:
/Users/aserbin/Projects/mini-cluster/kudu/thirdparty/src/gperftools-2.6.90/src/tests/tcmalloc_unittest.cc:1382:5: error:
aligned deallocation function of type 'void (void *, std::size_t, std::align_val_t) throw()'
is only available on macOS 10.13 or newer [-Waligned-allocation-unavailable]
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2019 00:09:54 +0000
Gerrit-HasComments: No