You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jrmccluskey (via GitHub)" <gi...@apache.org> on 2023/08/22 14:49:56 UTC
[GitHub] [beam] jrmccluskey commented on a diff in pull request #28083: [prism] support single external env pipelines.
jrmccluskey commented on code in PR #28083:
URL: https://github.com/apache/beam/pull/28083#discussion_r1301769781
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -47,7 +47,8 @@ func RunPipeline(j *jobservices.Job) {
// environments, and start up docker containers, but
// here, we only want and need the go one, operating
// in loopback mode.
- env := "go"
+ envs := j.Pipeline.GetComponents().GetEnvironments()
+ env, _ := getOnlyPair(envs)
Review Comment:
Would we get an actionable error here if this was misconfigured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org