You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by gr...@apache.org on 2001/02/01 22:02:52 UTC
cvs commit: xml-cocoon/src/org/apache/cocoon/processor/xslt XSLTProcessor.java
greenrd 01/02/01 13:02:51
Modified: . changes.xml
src/org/apache/cocoon/processor/xslt XSLTProcessor.java
Log:
dumb caching fix
Revision Changes Path
1.204 +6 -2 xml-cocoon/changes.xml
Index: changes.xml
===================================================================
RCS file: /home/cvs/xml-cocoon/changes.xml,v
retrieving revision 1.203
retrieving revision 1.204
diff -u -r1.203 -r1.204
--- changes.xml 2001/01/27 14:15:24 1.203
+++ changes.xml 2001/02/01 21:02:47 1.204
@@ -4,7 +4,7 @@
<!--
History of Cocoon changes
- $Id: changes.xml,v 1.203 2001/01/27 14:15:24 greenrd Exp $
+ $Id: changes.xml,v 1.204 2001/02/01 21:02:47 greenrd Exp $
-->
<changes title="History of Changes">
@@ -18,6 +18,9 @@
</devs>
<release version="@version@" date="@date@">
+ <action dev="RDG" type="fix" due-to="Sebastien Koechlin" due-to-email="skoechlin@ivision.fr">
+ Reversed change in 1.8.1 that ignored query string for XSLTProcessor caching
+ </action>
<action dev="RDG" type="update">
Changed default XSP encoding to UTF8, so that all characters are supported.
</action>
@@ -76,7 +79,8 @@
<release version="1.8.1" date="January 19 2001">
<action dev="RDG" type="fix" due-to="Wayne Bayever" due-to-email="wbayever@yahoo.com">
- XSLT stylesheet caching now ignores query string, as it should.
+ *** NOTE: This was a mistaken change that was later reversed in 1.8.3 - see above. ***
+ XSLTProcessor caching now ignores query string.
</action>
<action dev="RDG" type="update">
Removed headers from cache key because this was breaking caching in 90% of static cases.
1.27 +4 -4 xml-cocoon/src/org/apache/cocoon/processor/xslt/XSLTProcessor.java
Index: XSLTProcessor.java
===================================================================
RCS file: /home/cvs/xml-cocoon/src/org/apache/cocoon/processor/xslt/XSLTProcessor.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- XSLTProcessor.java 2001/01/19 00:23:48 1.26
+++ XSLTProcessor.java 2001/02/01 21:02:50 1.27
@@ -1,4 +1,4 @@
-/*-- $Id: XSLTProcessor.java,v 1.26 2001/01/19 00:23:48 greenrd Exp $ --
+/*-- $Id: XSLTProcessor.java,v 1.27 2001/02/01 21:02:50 greenrd Exp $ --
============================================================================
The Apache Software License, Version 1.1
@@ -75,7 +75,7 @@
* This class implements an XSLT processor.
*
* @author <a href="mailto:stefano@apache.org">Stefano Mazzocchi</a>
- * @version $Revision: 1.26 $ $Date: 2001/01/19 00:23:48 $
+ * @version $Revision: 1.27 $ $Date: 2001/02/01 21:02:50 $
*/
public class XSLTProcessor implements Actor, Processor, Status, Defaults, Cacheable {
@@ -251,7 +251,7 @@
if ((o != null) && (!sheetMonitor.hasChanged(resource))) {
return (Document) o;
} else {
- String encReq = Utils.encode (request, true, false);
+ String encReq = Utils.encode (request);
// resource URI might have changed so invalidate previous
requestMonitor.invalidate(encReq);
Document sheet = getDocument(resource);
@@ -271,7 +271,7 @@
}
public boolean hasChanged(Object context) {
- return requestMonitor.hasChanged(Utils.encode((HttpServletRequest) context, true, false));
+ return requestMonitor.hasChanged(Utils.encode((HttpServletRequest) context));
}
public boolean isCacheable(HttpServletRequest request) {