You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/09/24 08:02:10 UTC
Review Request 25986: Added reconcileTasks to python scheduler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
The last step of wiring up reconcileTasks in the python bindings.
Diffs
-----
src/python/interface/src/mesos/interface/__init__.py 818f41b
Diff: https://reviews.apache.org/r/25986/diff/
Testing
-------
Functional testing
Thanks,
Niklas Nielsen
Re: Review Request 25986: Added reconcileTasks to python scheduler.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Sept. 25, 2014, 2:08 p.m., Ben Mahler wrote:
> > Great, didn't realize this was all that's needed for MESOS-1461, I'll assign that to you.
> >
> > Can you link the ticket into this review?
Yeah - wired everything up but the last step :-P
We should wire task reconciliation up in the test frameworks to exercise the api.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/#review54597
-----------------------------------------------------------
On Sept. 25, 2014, 2:09 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25986/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 2:09 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1461
> https://issues.apache.org/jira/browse/MESOS-1461
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The last step of wiring up reconcileTasks in the python bindings.
>
>
> Diffs
> -----
>
> src/python/interface/src/mesos/interface/__init__.py 818f41b
>
> Diff: https://reviews.apache.org/r/25986/diff/
>
>
> Testing
> -------
>
> Functional testing
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 25986: Added reconcileTasks to python scheduler.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/#review54597
-----------------------------------------------------------
Ship it!
Great, didn't realize this was all that's needed for MESOS-1461, I'll assign that to you.
Can you link the ticket into this review?
- Ben Mahler
On Sept. 24, 2014, 6:02 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25986/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 6:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The last step of wiring up reconcileTasks in the python bindings.
>
>
> Diffs
> -----
>
> src/python/interface/src/mesos/interface/__init__.py 818f41b
>
> Diff: https://reviews.apache.org/r/25986/diff/
>
>
> Testing
> -------
>
> Functional testing
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 25986: Added reconcileTasks to python scheduler.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/#review54395
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25986]
All tests passed.
- Mesos ReviewBot
On Sept. 24, 2014, 6:02 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25986/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 6:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The last step of wiring up reconcileTasks in the python bindings.
>
>
> Diffs
> -----
>
> src/python/interface/src/mesos/interface/__init__.py 818f41b
>
> Diff: https://reviews.apache.org/r/25986/diff/
>
>
> Testing
> -------
>
> Functional testing
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 25986: Added reconcileTasks to python scheduler.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 9:09 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Linked in MESOS-1461.
--bmahler
Bugs: MESOS-1461
https://issues.apache.org/jira/browse/MESOS-1461
Repository: mesos-git
Description
-------
The last step of wiring up reconcileTasks in the python bindings.
Diffs
-----
src/python/interface/src/mesos/interface/__init__.py 818f41b
Diff: https://reviews.apache.org/r/25986/diff/
Testing
-------
Functional testing
Thanks,
Niklas Nielsen