You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "HundalTaran (via GitHub)" <gi...@apache.org> on 2026/06/09 12:21:42 UTC
[PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
HundalTaran opened a new pull request, #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269
Hi @ferenc-csaky,
I have observed that there is a missing kafka.yml file in v5.0 release due to which there is some misleading information in the documentation of Flink as shown in the image:
<img width="911" height="338" alt="flinkdocumentationissue" src="https://github.com/user-attachments/assets/37a4cb34-f263-4500-ac14-45b71474f299" />
Please verify this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on code in PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269#discussion_r3380663687
##########
docs/data/kafka.yml:
##########
@@ -0,0 +1,23 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+version: 5.0.0
Review Comment:
I just saw this is pointed against `main`. Either point it against the `v5.0` branch or change this version to `5.1-SNAPSHOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky merged PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269#issuecomment-4659653960
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269#issuecomment-4659810150
This probably will not be enough though, cause the doc site did not got a rebuild since May 22nd, and I have no clue what triggers that. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "HundalTaran (via GitHub)" <gi...@apache.org>.
HundalTaran commented on code in PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269#discussion_r3380690029
##########
docs/data/kafka.yml:
##########
@@ -0,0 +1,23 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+version: 5.0.0
Review Comment:
Thanks for pointing out. I have changed the base branch. Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix depenedency version of kafka connector in documentation [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #269:
URL: https://github.com/apache/flink-connector-kafka/pull/269#issuecomment-4661409164
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org