You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/28 14:29:18 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #284: [tooling] Use 7 letter hash in release scripts
gyfora opened a new pull request, #284:
URL: https://github.com/apache/flink-kubernetes-operator/pull/284
Newer git clients seem to return 8 letter hashes sometimes by default. This fix ensures that our release scripts always uses only the first 7 letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #284: [tooling] Use 7 letter hash in release scripts
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #284:
URL: https://github.com/apache/flink-kubernetes-operator/pull/284#issuecomment-1168860489
@gyfora out of curiosity, it's a big deal whether we hold 7 or 8 letter hash in release script? Or just for reproducing stably?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #284: [tooling] Use 7 letter hash in release scripts
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #284:
URL: https://github.com/apache/flink-kubernetes-operator/pull/284#issuecomment-1168872076
@tisonkun we had a hiccup with generating the 1.0.1 release due to this, as the git version might be different between the GitHub Action that tags the operator docker image and local machine of the committer preparing the release and can result in the Helm chart pointing to an invalid docker container. Fair question though 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #284: [tooling] Use 7 letter hash in release scripts
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #284:
URL: https://github.com/apache/flink-kubernetes-operator/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org