You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Leviev (JIRA)" <ji...@apache.org> on 2006/12/31 15:31:22 UTC
[jira] Created: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
[drlvm][vmcore][jit] Unsynchronized linked list modification
------------------------------------------------------------
Key: HARMONY-2933
URL: http://issues.apache.org/jira/browse/HARMONY-2933
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Ilya Leviev
Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-2933.
----------------------------------------
Resolution: Fixed
Patch applied at 504560. Please check that it was applied as expected.
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Assigned To: Gregory Shimansky
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-2933) [drlvm][vmcore][jit]
Unsynchronized linked list modification
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462079 ]
Ilya Berezhniuk commented on HARMONY-2933:
------------------------------------------
I suggest using the same patch but without trailing whitespaces.
Updated patch is attached.
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-2933:
-------------------------------------
Attachment: HARMONY-2933-vmcore-jit-add-synchronization.patch
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Ilya Leviev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2933?page=all ]
Ilya Leviev updated HARMONY-2933:
---------------------------------
Attachment: HARMONY-2933-vmcore-jit-add-synchronization.patch
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: http://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Ilya Leviev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Leviev updated HARMONY-2933:
---------------------------------
Patch Info: [Patch Available]
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Assigned To: Gregory Shimansky
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-2933.
--------------------------------------
No response, assuming ok.
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Assignee: Gregory Shimansky
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-2933:
---------------------------------------
Patch Info: (was: [Patch Available])
Assignee: Gregory Shimansky
I don't like the way you fix unsynchronized access. You're adding a new static lock inside of the file, this is not good for multiple VM support in the future. I think that lock for dcList should be added in the same VM_Global_State as dcList itself and Lock_Manager object should be initialized on VM startup.
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Assigned To: Gregory Shimansky
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-2933:
-------------------------------------
Attachment: HARMONY-2933-vmcore-jit-add-synchronization.patch
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2933) [drlvm][vmcore][jit] Unsynchronized
linked list modification
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-2933:
-------------------------------------
Attachment: HARMONY-2933-vmcore-jit-add-synchronization.patch
Suggested patch synchronizes access by lock manager relying in GlobalEnv.
Access to dynamic code list is now synchronized in all places where it's used.
> [drlvm][vmcore][jit] Unsynchronized linked list modification
> ------------------------------------------------------------
>
> Key: HARMONY-2933
> URL: https://issues.apache.org/jira/browse/HARMONY-2933
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Ilya Leviev
> Assigned To: Gregory Shimansky
> Attachments: HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch, HARMONY-2933-vmcore-jit-add-synchronization.patch
>
>
> Unsynchronized linked list modification at vm\vmcore\src\jit\compile.cpp in function compile_add_dynamic_generated_code_chunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.