You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/12 00:29:11 UTC

Review Request 47272: GEODE-1350: Provide local fix for Category and Parameterized test issue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47272/
-----------------------------------------------------------

Review request for geode, Jinmei Liao and Kirk Lund.


Repository: geode


Description
-------

GEODE-1350: Provide local fix for Category and Parameterized test issue


Diffs
-----

  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunner.java PRE-CREATION 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactory.java PRE-CREATION 
  geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/ExposedGetAnnotations.java PRE-CREATION 
  geode-junit/src/test/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactoryTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/47272/diff/


Testing
-------


Thanks,

Jens Deppe


Re: Review Request 47272: GEODE-1350: Provide local fix for Category and Parameterized test issue

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47272/#review133001
-----------------------------------------------------------


Ship it!




Looks like you had fun writing the test ;) Ship It!

- Kirk Lund


On May 12, 2016, 12:29 a.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47272/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 12:29 a.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1350: Provide local fix for Category and Parameterized test issue
> 
> 
> Diffs
> -----
> 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunner.java PRE-CREATION 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactory.java PRE-CREATION 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/ExposedGetAnnotations.java PRE-CREATION 
>   geode-junit/src/test/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactoryTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47272/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>


Re: Review Request 47272: GEODE-1350: Provide local fix for Category and Parameterized test issue

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47272/#review133109
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On May 12, 2016, 12:29 a.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47272/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 12:29 a.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1350: Provide local fix for Category and Parameterized test issue
> 
> 
> Diffs
> -----
> 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunner.java PRE-CREATION 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactory.java PRE-CREATION 
>   geode-junit/src/main/java/com/gemstone/gemfire/test/junit/runners/ExposedGetAnnotations.java PRE-CREATION 
>   geode-junit/src/test/java/com/gemstone/gemfire/test/junit/runners/CategoryWithParameterizedRunnerFactoryTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47272/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>