You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/07/27 08:10:48 UTC

[GitHub] storm pull request #2776: STORM-3161 Local mode should force setting min rep...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/2776

    STORM-3161 Local mode should force setting min replication count to 1

    When topology.min.replication.count is set to more than 1, nimbus in local mode
    never achieve condition for replication, hence stuck on handling blobs.
    
    We should force set it to 1 in local mode to avoid this situation.
    
    Will also submit patch for 1.x-branch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-3161

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2776
    
----
commit 882cfff9f8249248ff09b5898389523512ede40b
Author: Jungtaek Lim <ka...@...>
Date:   2018-07-27T07:58:37Z

    STORM-3161 Local mode should force setting min replication count to 1
    
    When topology.min.replication.count is set to more than 1, nimbus in local mode
    never achieve condition for replication, hence stuck on handling blobs.
    We should force set it to 1 in local mode to avoid this situation.

----


---

[GitHub] storm issue #2776: STORM-3161 Local mode should force setting min replicatio...

Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:

    https://github.com/apache/storm/pull/2776
  
    @HeartSaVioR 
    What is the wrong stake trace, to be stuck on handling blobs, you mean topologies will not get any jar/conf/ser ?


---

[GitHub] storm issue #2776: STORM-3161 Local mode should force setting min replicatio...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2776
  
    @danny0405 It is not an error but stuck with no update. 
    
    https://github.com/apache/storm/blob/3b5f9e7c75b378881060f454d39e6bf653e0bcb3/storm-core/src/clj/org/apache/storm/daemon/nimbus.clj#L502
    
    In local mode we always launch only one nimbus, hence never achieve replication if min replication count is set to higher than 1.


---

[GitHub] storm pull request #2776: STORM-3161 Local mode should force setting min rep...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2776


---

[GitHub] storm issue #2776: STORM-3161 Local mode should force setting min replicatio...

Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:

    https://github.com/apache/storm/pull/2776
  
    +1


---