You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/05/06 14:53:03 UTC
Review Request: CLOUDSTACK-2189 volume is stuck in resizing state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and edison su.
Description
-------
After resize operation, the state of the volume is resizing only.
The issue is, VolumeServiceImpl is calling the wrong call back for the resize volume operation.
Fixed the issue by calling the right callback which will change the state transition from resizing to Ready.
This addresses bug CLOUDSTACK-2189.
Diffs
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
Diff: https://reviews.apache.org/r/10947/diff/
Testing
-------
Unittests are success.
Created a volume of 5 GB, verified the state in the db and in the kvm.
Resized the volume to 20GB, volume attached to the kvm instance had increased to 20GB, resizevolume logs shows the volume is increased.
DB is now having the state change from Resizing to Ready.
The testing output is pasted on the bug comment
Thanks,
Rajesh Battala
Re: Review Request: CLOUDSTACK-2189 volume is stuck in resizing state
Posted by Devdeep Singh <de...@citrix.com>.
> On May 8, 2013, 8:56 a.m., Devdeep Singh wrote:
> > Ship It!
Can a committer merge these changes?
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/#review20300
-----------------------------------------------------------
On May 6, 2013, 12:53 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10947/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> After resize operation, the state of the volume is resizing only.
> The issue is, VolumeServiceImpl is calling the wrong call back for the resize volume operation.
> Fixed the issue by calling the right callback which will change the state transition from resizing to Ready.
>
>
> This addresses bug CLOUDSTACK-2189.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/10947/diff/
>
>
> Testing
> -------
>
> Unittests are success.
> Created a volume of 5 GB, verified the state in the db and in the kvm.
> Resized the volume to 20GB, volume attached to the kvm instance had increased to 20GB, resizevolume logs shows the volume is increased.
> DB is now having the state change from Resizing to Ready.
>
> The testing output is pasted on the bug comment
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: CLOUDSTACK-2189 volume is stuck in resizing state
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/#review20300
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On May 6, 2013, 12:53 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10947/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> After resize operation, the state of the volume is resizing only.
> The issue is, VolumeServiceImpl is calling the wrong call back for the resize volume operation.
> Fixed the issue by calling the right callback which will change the state transition from resizing to Ready.
>
>
> This addresses bug CLOUDSTACK-2189.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/10947/diff/
>
>
> Testing
> -------
>
> Unittests are success.
> Created a volume of 5 GB, verified the state in the db and in the kvm.
> Resized the volume to 20GB, volume attached to the kvm instance had increased to 20GB, resizevolume logs shows the volume is increased.
> DB is now having the state change from Resizing to Ready.
>
> The testing output is pasted on the bug comment
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: CLOUDSTACK-2189 volume is stuck in resizing state
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10947/#review20479
-----------------------------------------------------------
Ship it!
Branch: refs/heads/master
Commit: 756a4179e28b66fe42fec40c0b183907eab0dde2
- Sateesh Chodapuneedi
On May 6, 2013, 12:53 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10947/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> After resize operation, the state of the volume is resizing only.
> The issue is, VolumeServiceImpl is calling the wrong call back for the resize volume operation.
> Fixed the issue by calling the right callback which will change the state transition from resizing to Ready.
>
>
> This addresses bug CLOUDSTACK-2189.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/10947/diff/
>
>
> Testing
> -------
>
> Unittests are success.
> Created a volume of 5 GB, verified the state in the db and in the kvm.
> Resized the volume to 20GB, volume attached to the kvm instance had increased to 20GB, resizevolume logs shows the volume is increased.
> DB is now having the state change from Resizing to Ready.
>
> The testing output is pasted on the bug comment
>
>
> Thanks,
>
> Rajesh Battala
>
>