You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2020/05/15 16:52:43 UTC
Re: dubbo-build-tools?
Correct. This change is introduced to make sure all files should have a
intended ASF header.
-Ian.
On Tue, Apr 28, 2020 at 11:10 AM Kevin Albumen <jh...@hotmail.com> wrote:
> Hello,
>
> According to the git history, the dubbo-build-tools is created by #6060<
> https://github.com/apache/dubbo/pull/6060>, and its role is to provide a
> checkstyle-header.txt<
> https://github.com/apache/dubbo/blob/master/dubbo-build-tools/src/main/resources/checkstyle-header.txt>
> file.
> This file will provide a template to make files consistent when checking
> ASF license header for java files.
>
> ________________________________
> 发件人: YunKun Huang <ht...@gmail.com>
> 发送时间: 2020年4月28日 10:12
> 收件人: Dubbo Dev Group <de...@dubbo.apache.org>
> 主题: dubbo-build-tools?
>
> hey,
>
> I notice our snapshot deployment job fail recently (
>
> https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-snapshot-deployment/1036/consoleFull
> ),
> but travis ci is passing.
>
> According to jenkins log, it looks like there is a new module named `
> dubbo-build-tools` which fail snapshot deployment process.
>
> Does anyone have idea about this? what's the purpose of this?
>
Re: dubbo-build-tools?
Posted by Ian Luo <ia...@gmail.com>.
Not sure, haven't not had chance to look into the details. Would you mind
to fire an issue on GitHub and ping the original author, @mercyblitz?
Thanks,
-Ian.
On Sun, May 17, 2020 at 9:06 PM YunKun Huang <ht...@gmail.com> wrote:
> why we need a new subproject for this?
> can rat-plugin or checkstyle-plugin meet the requirements?
>
> it's so weird that there is a subproject with version 1.0.0 and include in
> dubbo-all project.
> do we need this one deploy to repo? what's the version strategry for this
> project?
>
> On Sat, May 16, 2020 at 12:52 AM Ian Luo <ia...@gmail.com> wrote:
>
> > Correct. This change is introduced to make sure all files should have a
> > intended ASF header.
> >
> > -Ian.
> >
> > On Tue, Apr 28, 2020 at 11:10 AM Kevin Albumen <jh...@hotmail.com>
> > wrote:
> >
> > > Hello,
> > >
> > > According to the git history, the dubbo-build-tools is created by
> #6060<
> > > https://github.com/apache/dubbo/pull/6060>, and its role is to
> provide a
> > > checkstyle-header.txt<
> > >
> >
> https://github.com/apache/dubbo/blob/master/dubbo-build-tools/src/main/resources/checkstyle-header.txt
> > >
> > > file.
> > > This file will provide a template to make files consistent when
> checking
> > > ASF license header for java files.
> > >
> > > ________________________________
> > > 发件人: YunKun Huang <ht...@gmail.com>
> > > 发送时间: 2020年4月28日 10:12
> > > 收件人: Dubbo Dev Group <de...@dubbo.apache.org>
> > > 主题: dubbo-build-tools?
> > >
> > > hey,
> > >
> > > I notice our snapshot deployment job fail recently (
> > >
> > >
> >
> https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-snapshot-deployment/1036/consoleFull
> > > ),
> > > but travis ci is passing.
> > >
> > > According to jenkins log, it looks like there is a new module named `
> > > dubbo-build-tools` which fail snapshot deployment process.
> > >
> > > Does anyone have idea about this? what's the purpose of this?
> > >
> >
>
Re: dubbo-build-tools?
Posted by YunKun Huang <ht...@gmail.com>.
why we need a new subproject for this?
can rat-plugin or checkstyle-plugin meet the requirements?
it's so weird that there is a subproject with version 1.0.0 and include in
dubbo-all project.
do we need this one deploy to repo? what's the version strategry for this
project?
On Sat, May 16, 2020 at 12:52 AM Ian Luo <ia...@gmail.com> wrote:
> Correct. This change is introduced to make sure all files should have a
> intended ASF header.
>
> -Ian.
>
> On Tue, Apr 28, 2020 at 11:10 AM Kevin Albumen <jh...@hotmail.com>
> wrote:
>
> > Hello,
> >
> > According to the git history, the dubbo-build-tools is created by #6060<
> > https://github.com/apache/dubbo/pull/6060>, and its role is to provide a
> > checkstyle-header.txt<
> >
> https://github.com/apache/dubbo/blob/master/dubbo-build-tools/src/main/resources/checkstyle-header.txt
> >
> > file.
> > This file will provide a template to make files consistent when checking
> > ASF license header for java files.
> >
> > ________________________________
> > 发件人: YunKun Huang <ht...@gmail.com>
> > 发送时间: 2020年4月28日 10:12
> > 收件人: Dubbo Dev Group <de...@dubbo.apache.org>
> > 主题: dubbo-build-tools?
> >
> > hey,
> >
> > I notice our snapshot deployment job fail recently (
> >
> >
> https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-snapshot-deployment/1036/consoleFull
> > ),
> > but travis ci is passing.
> >
> > According to jenkins log, it looks like there is a new module named `
> > dubbo-build-tools` which fail snapshot deployment process.
> >
> > Does anyone have idea about this? what's the purpose of this?
> >
>