You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/17 18:59:55 UTC
[kudu-CR](branch-1.11.x) [clock] clean up hybrid clock-test
Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14490
to review the following change.
Change subject: [clock] clean up hybrid_clock-test
......................................................................
[clock] clean up hybrid_clock-test
This patch contains a small clean up on the HybridClockTest:
* added ASSERT/CHECK for methods returning Status
* added scoped cleanup into TestClockDoesntGoBackwardsWithUpdates
Change-Id: I1c62cf51e11041b2369d29ff4f714876fd352cea
Reviewed-on: http://gerrit.cloudera.org:8080/14474
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 22f0ea360a5f8b820631248a60fd8c1c879d81e4)
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 23 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/14490/1
--
To view, visit http://gerrit.cloudera.org:8080/14490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c62cf51e11041b2369d29ff4f714876fd352cea
Gerrit-Change-Number: 14490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [clock] clean up hybrid clock-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14490 )
Change subject: [clock] clean up hybrid_clock-test
......................................................................
[clock] clean up hybrid_clock-test
This patch contains a small clean up on the HybridClockTest:
* added ASSERT/CHECK for methods returning Status
* added scoped cleanup into TestClockDoesntGoBackwardsWithUpdates
Change-Id: I1c62cf51e11041b2369d29ff4f714876fd352cea
Reviewed-on: http://gerrit.cloudera.org:8080/14474
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 22f0ea360a5f8b820631248a60fd8c1c879d81e4)
Reviewed-on: http://gerrit.cloudera.org:8080/14490
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 23 insertions(+), 22 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c62cf51e11041b2369d29ff4f714876fd352cea
Gerrit-Change-Number: 14490
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [clock] clean up hybrid clock-test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14490 )
Change subject: [clock] clean up hybrid_clock-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c62cf51e11041b2369d29ff4f714876fd352cea
Gerrit-Change-Number: 14490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 20:24:34 +0000
Gerrit-HasComments: No