[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4812: Spark 3.2: Support reading position deletes

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #4812:
URL: https://github.com/apache/iceberg/pull/4812#discussion_r902986896


##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -108,6 +108,29 @@ public static DataFile fromManifest(ManifestFile manifest) {
         .build();
   }
 
+  public static DataFile fromPositionDelete(DeleteFile deleteFile, PartitionSpec spec) {

Review Comment:
   Do we need an assert here to make sure someone doesn't pass through an Equality delete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org