You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2008/10/27 09:04:44 UTC

[jira] Created: (HAMA-92) Add subVector(int i0, int i1, int j0, int j1) to Matrix

Add subVector(int i0, int i1, int j0, int j1) to Matrix
-------------------------------------------------------

                 Key: HAMA-92
                 URL: https://issues.apache.org/jira/browse/HAMA-92
             Project: Hama
          Issue Type: Improvement
          Components: implementation, interface
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.1.0


I propose a submatrix method as describe below.

  /**
   * Returns the sub-matrix of matrix
   * 
   * @param i0 the start index of row
   * @param i1 the end index of row
   * @param j0 the start index of column
   * @param j1 the end index of column
   * @return the sub-matrix of matrix
   * @throws IOException
   */
  public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-92:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Resolved.

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-92.patch
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-92) Add subVector(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642880#action_12642880 ] 

Edward J. Yoon commented on HAMA-92:
------------------------------------

DenseMatrix was implemented using Hbase API.
So, If we want to use a submatrix such as DenseMatrix, we should write to table. (or, other choices.)

> Add subVector(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-92:
-------------------------------

    Attachment: HAMA-92.patch

Here's the patch. I add a SubMatrix class.

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-92.patch
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-92:
-------------------------------

    Summary: Add subMatrix(int i0, int i1, int j0, int j1) to Matrix  (was: Add subVector(int i0, int i1, int j0, int j1) to Matrix)

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-92:
-------------------------------

    Status: Patch Available  (was: Open)

Submit to hudson.

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-92.patch
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643143#action_12643143 ] 

Hudson commented on HAMA-92:
----------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12392911/HAMA-92.patch
against trunk revision 708431.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/102/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/102/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/102/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/102/console

This message is automatically generated.

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-92.patch
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-92) Add subVector(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642873#action_12642873 ] 

Edward J. Yoon commented on HAMA-92:
------------------------------------

Hmm,,,  let's replace Matrix subMatrix() to double[][] subMatrix().

> Add subVector(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-92) Add subMatrix(int i0, int i1, int j0, int j1) to Matrix

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643108#action_12643108 ] 

Edward J. Yoon commented on HAMA-92:
------------------------------------

Re-propose as describe below.

  /**
   * Returns the sub matrix formed by selecting certain rows and
   * columns from a bigger matrix. This is a in-memory operation only.
   * 
   * @param i0 the start index of row
   * @param i1 the end index of row
   * @param j0 the start index of column
   * @param j1 the end index of column
   * @return the sub matrix of matrix
   * @throws IOException
   */
  public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

> Add subMatrix(int i0, int i1, int j0, int j1) to Matrix
> -------------------------------------------------------
>
>                 Key: HAMA-92
>                 URL: https://issues.apache.org/jira/browse/HAMA-92
>             Project: Hama
>          Issue Type: Improvement
>          Components: implementation, interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>
> I propose a submatrix method as describe below.
>   /**
>    * Returns the sub-matrix of matrix
>    * 
>    * @param i0 the start index of row
>    * @param i1 the end index of row
>    * @param j0 the start index of column
>    * @param j1 the end index of column
>    * @return the sub-matrix of matrix
>    * @throws IOException
>    */
>   public Matrix subMatrix(int i0, int i1, int j0, int j1) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.