svn commit: r882262 - /apr/apr/branches/1.4.x/include/apr_strings.h

[tr...@apache.org]

Author: trawick
Date: Thu Nov 19 19:36:53 2009
New Revision: 882262

URL: http://svn.apache.org/viewvc?rev=882262&view=rev
Log:
Merge r882260 from trunk:

document errno usage with apr_atoi64() and apr_itoa()

Modified:
    apr/apr/branches/1.4.x/include/apr_strings.h

Modified: apr/apr/branches/1.4.x/include/apr_strings.h
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.4.x/include/apr_strings.h?rev=882262&r1=882261&r2=882262&view=diff
==============================================================================
--- apr/apr/branches/1.4.x/include/apr_strings.h (original)
+++ apr/apr/branches/1.4.x/include/apr_strings.h Thu Nov 19 19:36:53 2009
@@ -334,7 +334,7 @@
  *   digits are prefixed with '0x', in which case it will be treated as
  *   base 16.
  * @return The numeric value of the string.  On overflow, errno is set
- * to ERANGE.
+ * to ERANGE.  On success, errno is set to 0.
  */
 APR_DECLARE(apr_int64_t) apr_strtoi64(const char *buf, char **end, int base);
 
@@ -342,7 +342,8 @@
  * parse a base-10 numeric string into a 64-bit numeric value.
  * Equivalent to apr_strtoi64(buf, (char**)NULL, 10).
  * @param buf The string to parse
- * @return The numeric value of the string
+ * @return The numeric value of the string.  On overflow, errno is set
+ * to ERANGE.  On success, errno is set to 0.
  */
 APR_DECLARE(apr_int64_t) apr_atoi64(const char *buf);
 

Re: svn commit: r882262 - /apr/apr/branches/1.4.x/include/apr_strings.h

[Jeff Trawick <tr...@gmail.com>]

On Thu, Nov 19, 2009 at 2:36 PM,  <tr...@apache.org> wrote:
> Author: trawick
> Date: Thu Nov 19 19:36:53 2009
> New Revision: 882262
>
> URL: http://svn.apache.org/viewvc?rev=882262&view=rev
> Log:
> Merge r882260 from trunk:
>
> document errno usage with apr_atoi64() and apr_itoa()

err, make that apr_atoi64 and apr_strtoi64

I guess this doc shouldn't be fixed in the 1.3.x branch because of a
code fix that was necessary in the 1.3.x lifetime...

Changes for APR 1.3.4

  *) Reset errno to zero in apr_strtoi64 to prevent returning an errno not
     equal zero in cases where the operation worked fine. [Ruediger Pluem]