You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Mark Thomas (JIRA)" <ji...@apache.org> on 2013/12/20 11:10:10 UTC
[jira] [Resolved] (POOL-245) [PATCH] Typo and remove duplicate null
check
[ https://issues.apache.org/jira/browse/POOL-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Thomas resolved POOL-245.
------------------------------
Resolution: Fixed
Fix Version/s: 2.1
Thanks for the patch. I applied it but with a few changes:
- there were lots of cases of "it's" rather than "its" so I fixed them all.
- I removed rather than commented out the duplicate check to reduce the clutter in the code base.
Thanks again for the patch - on to your next one ;)
> [PATCH] Typo and remove duplicate null check
> --------------------------------------------
>
> Key: POOL-245
> URL: https://issues.apache.org/jira/browse/POOL-245
> Project: Commons Pool
> Issue Type: Improvement
> Reporter: Bruno P. Kinoshita
> Priority: Trivial
> Labels: patch, typo
> Fix For: 2.1
>
> Attachments: POOL-245.patch
>
>
> This patch fixes a trivial typo in PoolUtils javadocs, and removes a duplicate null check. There is no way (besides reflection, mocking, etc) to test both null checks.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)