You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sadhen <gi...@git.apache.org> on 2018/08/29 07:36:23 UTC
[GitHub] spark pull request #22260: [SQL][MINOR] Fix compiling for scala 2.12
Github user sadhen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22260#discussion_r213573236
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ProjectionOverSchema.scala ---
@@ -38,7 +38,7 @@ private[execution] case class ProjectionOverSchema(schema: StructType) {
case GetArrayItem(child, arrayItemOrdinal) =>
getProjection(child).map { projection => GetArrayItem(projection, arrayItemOrdinal) }
case a: GetArrayStructFields =>
- getProjection(a.child).map(p => (p, p.dataType)).map {
+ getProjection(a.child).map(p => (p, p.dataType)).collect {
--- End diff --
Well, there is a semantic change using `collect`. I will provide a unit test to verify the change or simply using `sys.error`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org