You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "lishuxu (via GitHub)" <gi...@apache.org> on 2026/10/12 09:01:38 UTC
[PR] fix(rest): improve REST catalog configuration and error handling [iceberg-cpp]
lishuxu opened a new pull request, #1003:
URL: https://github.com/apache/iceberg-cpp/pull/1003
This commit improves the robustness of REST catalog operations:
- Disable HTTP redirects in REST catalog requests to prevent unexpected behavior with signed requests and custom authentication headers
- Filter server-provided configuration to prevent override of client-specified authentication settings
- Improve JSON parse error messages to avoid exposing sensitive data in logs by reporting only type information instead of full values
- Add log sanitizer utility to redact sensitive configuration values from application logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(json): omit JSON values from parse errors [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #1003:
URL: https://github.com/apache/iceberg-cpp/pull/1003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest): improve REST catalog configuration and error handling [iceberg-cpp]
Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli commented on code in PR #1003:
URL: https://github.com/apache/iceberg-cpp/pull/1003#discussion_r4304041645
##########
src/iceberg/util/json_util_internal.h:
##########
@@ -57,6 +57,10 @@ inline void SetOptionalStringField(nlohmann::json& json, std::string_view key,
}
}
+/// \brief Dump a JSON document to a string, ignoring encoding errors.
+///
+/// Not intended for error messages: parse errors describe the offending key
+/// and JSON type instead of reproducing JSON values.
inline std::string SafeDumpJson(const nlohmann::json& json) {
Review Comment:
After this change SafeDumpJson has no callers left anywhere under src. Deleting it would enforce the rule the new doc comment describes, instead of leaving the helper around for the next error message to reach for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org