You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/08/01 01:46:08 UTC

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2187#discussion_r206733019
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -189,16 +185,24 @@ public void kill() {
           this.killed = true;
        }
     
    +   private void setHandlers() {
    +      sessionChannel.setCommandConfirmationHandler(commandConfirmationHandler);
    --- End diff --
    
    @michaelandrepearce is this ready to be merged in your opinion?


---