You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Jonathan Anstey <ja...@iona.com> on 2007/02/12 17:48:22 UTC
Patch for QPID-365
Hi everyone,
I created a patch for QPID-365. Could someone comment on or apply this
patch for me?
Thanks,
Jonathan Anstey
Re: Patch for QPID-365
Posted by Jonathan Anstey <ja...@iona.com>.
Thanks Rupert! It builds fine now.
Rupert Smith wrote:
> Done
>
> On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
>>
>> Sure, sounds good to me. I figured that you did intend to disable the
>> retrotranslator stuff by default. I just didn't think about setting up
>> dummy values to get around it. :-)
>>
>> Cheers,
>> Jon
>>
>> Rupert Smith wrote:
>> > Actually, can I submit a slightly different patch that sets these up
>> with
>> > dummy values to avoid this error? This would be better because maven
>> > would
>> > not try to verify by default but only when the correct values are set
>> > up in
>> > your settings.xml. This is what I was intending the behaviour to be.
>> >
>> > The reason I can't fill in these paths is because I can't make
>> > assumptions
>> > about where the JDK is located. I set verify to false by default,
>> without
>> > realising that these nulls would cause a problem. To use it with
>> > verification the correct paths need to be set up in your settings.xml.
>> >
>> > Rupert
>> >
>> > On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
>> >>
>> >> Hi everyone,
>> >>
>> >> I created a patch for QPID-365. Could someone comment on or apply
>> this
>> >> patch for me?
>> >>
>> >> Thanks,
>> >> Jonathan Anstey
>> >>
>> >
>>
>>
>
Re: Patch for QPID-365
Posted by Rupert Smith <ru...@googlemail.com>.
If you want to verify the retrotranslation add something like the following
in a suitable place in your settings.xml.
<!-- Configure retrotranslator verification stuff. -->
<retrotranslator.verify>true</retrotranslator.verify>
<retrotranslator.1.4-rt-path>c:/Program
Files/Java/j2re1.4.2_12/lib/rt.jar</retrotranslator.1.4-rt-path>
<retrotranslator.1.4-jce-path>c:/Program
Files/Java/j2re1.4.2_12/lib/jce.jar</retrotranslator.1.4-jce-path>
<retrotranslator.1.4-jsse-path>c:/Program
Files/Java/j2re1.4.2_12/lib/jsse.jar</retrotranslator.1.4-jsse-path>
You may notice that verification fails at the moment, because of missing
SASL stuff in 1.4
- Rupert
On 2/12/07, Rupert Smith <ru...@googlemail.com> wrote:
>
> Done
>
> On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
> >
> > Sure, sounds good to me. I figured that you did intend to disable the
> > retrotranslator stuff by default. I just didn't think about setting up
> > dummy values to get around it. :-)
> >
> > Cheers,
> > Jon
> >
> > Rupert Smith wrote:
> > > Actually, can I submit a slightly different patch that sets these up
> > with
> > > dummy values to avoid this error? This would be better because maven
> > > would
> > > not try to verify by default but only when the correct values are set
> > > up in
> > > your settings.xml. This is what I was intending the behaviour to be.
> > >
> > > The reason I can't fill in these paths is because I can't make
> > > assumptions
> > > about where the JDK is located. I set verify to false by default,
> > without
> > > realising that these nulls would cause a problem. To use it with
> > > verification the correct paths need to be set up in your settings.xml.
> > >
> > > Rupert
> > >
> > > On 2/12/07, Jonathan Anstey < janstey@iona.com> wrote:
> > >>
> > >> Hi everyone,
> > >>
> > >> I created a patch for QPID-365. Could someone comment on or apply
> > this
> > >> patch for me?
> > >>
> > >> Thanks,
> > >> Jonathan Anstey
> > >>
> > >
> >
> >
>
Re: Patch for QPID-365
Posted by Rupert Smith <ru...@googlemail.com>.
Done
On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
>
> Sure, sounds good to me. I figured that you did intend to disable the
> retrotranslator stuff by default. I just didn't think about setting up
> dummy values to get around it. :-)
>
> Cheers,
> Jon
>
> Rupert Smith wrote:
> > Actually, can I submit a slightly different patch that sets these up
> with
> > dummy values to avoid this error? This would be better because maven
> > would
> > not try to verify by default but only when the correct values are set
> > up in
> > your settings.xml. This is what I was intending the behaviour to be.
> >
> > The reason I can't fill in these paths is because I can't make
> > assumptions
> > about where the JDK is located. I set verify to false by default,
> without
> > realising that these nulls would cause a problem. To use it with
> > verification the correct paths need to be set up in your settings.xml.
> >
> > Rupert
> >
> > On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
> >>
> >> Hi everyone,
> >>
> >> I created a patch for QPID-365. Could someone comment on or apply this
> >> patch for me?
> >>
> >> Thanks,
> >> Jonathan Anstey
> >>
> >
>
>
Re: Patch for QPID-365
Posted by Jonathan Anstey <ja...@iona.com>.
Sure, sounds good to me. I figured that you did intend to disable the
retrotranslator stuff by default. I just didn't think about setting up
dummy values to get around it. :-)
Cheers,
Jon
Rupert Smith wrote:
> Actually, can I submit a slightly different patch that sets these up with
> dummy values to avoid this error? This would be better because maven
> would
> not try to verify by default but only when the correct values are set
> up in
> your settings.xml. This is what I was intending the behaviour to be.
>
> The reason I can't fill in these paths is because I can't make
> assumptions
> about where the JDK is located. I set verify to false by default, without
> realising that these nulls would cause a problem. To use it with
> verification the correct paths need to be set up in your settings.xml.
>
> Rupert
>
> On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
>>
>> Hi everyone,
>>
>> I created a patch for QPID-365. Could someone comment on or apply this
>> patch for me?
>>
>> Thanks,
>> Jonathan Anstey
>>
>
Re: Patch for QPID-365
Posted by Rupert Smith <ru...@googlemail.com>.
Actually, can I submit a slightly different patch that sets these up with
dummy values to avoid this error? This would be better because maven would
not try to verify by default but only when the correct values are set up in
your settings.xml. This is what I was intending the behaviour to be.
The reason I can't fill in these paths is because I can't make assumptions
about where the JDK is located. I set verify to false by default, without
realising that these nulls would cause a problem. To use it with
verification the correct paths need to be set up in your settings.xml.
Rupert
On 2/12/07, Jonathan Anstey <ja...@iona.com> wrote:
>
> Hi everyone,
>
> I created a patch for QPID-365. Could someone comment on or apply this
> patch for me?
>
> Thanks,
> Jonathan Anstey
>