You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2023/11/17 16:46:27 UTC

Re: [PR] Fix PartialOrd for ScalarValue::FixSizeList [arrow-datafusion]

comphead commented on code in PR #8253:
URL: https://github.com/apache/arrow-datafusion/pull/8253#discussion_r1397596668


##########
datafusion/common/src/utils.rs:
##########
@@ -390,6 +390,16 @@ pub fn arrays_into_list_array(
     ))
 }
 
+/// Get the child arrays from a `ArrayRef`.

Review Comment:
   Thanks @jayzhan211 
   I'm thinking of naming it nested instead of children, what do you think? 
   
   And would be super helpful to have a doc test or example input/output in the comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org