You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Andrew Hsu (JIRA)" <ji...@apache.org> on 2009/11/07 02:25:41 UTC

[jira] Created: (TS-22) Collect common defines into global configuration header

Collect common defines into global configuration header
-------------------------------------------------------

                 Key: TS-22
                 URL: https://issues.apache.org/jira/browse/TS-22
             Project: Traffic Server
          Issue Type: Improvement
          Components: Build
    Affects Versions: 2.0a
         Environment: All
            Reporter: Andrew Hsu
            Priority: Minor


The command lines to pass -D to g++ are quite long (passing in PACKAGE_VERSION, PACKAGE_NAME, etc).  They ought to be collected into a common 'config.h' file generated by autoheader:
http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers

The #include <config.h> needs to be placed before any other header files, to prevent inconsistencies in declarations (for example, if it redefines const).  Plus, not all files may need the include.

This change will likely touch a lot of *.c, *.cc, *.h, and *.i files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-22) Collect common defines into global configuration header

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-22:
----------------------------

    Fix Version/s: 2.1.0

> Collect common defines into global configuration header
> -------------------------------------------------------
>
>                 Key: TS-22
>                 URL: https://issues.apache.org/jira/browse/TS-22
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 2.0.0a
>         Environment: All
>            Reporter: Andrew Hsu
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> The command lines to pass -D to g++ are quite long (passing in PACKAGE_VERSION, PACKAGE_NAME, etc).  They ought to be collected into a common 'config.h' file generated by autoheader:
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
> The #include <config.h> needs to be placed before any other header files, to prevent inconsistencies in declarations (for example, if it redefines const).  Plus, not all files may need the include.
> This change will likely touch a lot of *.c, *.cc, *.h, and *.i files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (TS-22) Collect common defines into global configuration header

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom resolved TS-22.
-----------------------------

    Resolution: Fixed

I believe this is done.

> Collect common defines into global configuration header
> -------------------------------------------------------
>
>                 Key: TS-22
>                 URL: https://issues.apache.org/jira/browse/TS-22
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 2.0.0a
>         Environment: All
>            Reporter: Andrew Hsu
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> The command lines to pass -D to g++ are quite long (passing in PACKAGE_VERSION, PACKAGE_NAME, etc).  They ought to be collected into a common 'config.h' file generated by autoheader:
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
> The #include <config.h> needs to be placed before any other header files, to prevent inconsistencies in declarations (for example, if it redefines const).  Plus, not all files may need the include.
> This change will likely touch a lot of *.c, *.cc, *.h, and *.i files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira