You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/01/10 08:58:01 UTC
Review Request 29792: LENS-172: Fix and cleanup generate site script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-172
https://issues.apache.org/jira/browse/LENS-172
Repository: lens
Description
-------
Right now, RestAPI documentation link is not working. It is giving the following error:
HTTP ERROR 404
Problem accessing /rest.html. Reason:
NOT_FOUND
There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
cp -r $REST_DIR/* .
Diffs
-----
src/site/apt/user/rest.apt a71f56a
tools/scripts/generate-site-public.sh 448962d
Diff: https://reviews.apache.org/r/29792/diff/
Testing
-------
Vallidated on local machine by publishing the site to local filesystem location.
Thanks,
Raju Bairishetti
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 11, 2015, 2:37 a.m., Amareshwari Sriramadasu wrote:
> > tools/scripts/generate-site-public.sh, line 69
> > <https://reviews.apache.org/r/29792/diff/2/?file=816015#file816015line69>
> >
> > We need to check if svnpudsub publishes site from publish directory ot publish/current. I think it is publish. We need to change it to show current and provide links to versioned documentation - can be done in separate jira
I think it is better to avoid *current* term in site url. We can show the latest docs by default.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67602
-----------------------------------------------------------
On Jan. 10, 2015, 8:44 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 11, 2015, 2:37 a.m., Amareshwari Sriramadasu wrote:
> > tools/scripts/generate-site-public.sh, line 69
> > <https://reviews.apache.org/r/29792/diff/2/?file=816015#file816015line69>
> >
> > We need to check if svnpudsub publishes site from publish directory ot publish/current. I think it is publish. We need to change it to show current and provide links to versioned documentation - can be done in separate jira
>
> Raju Bairishetti wrote:
> I think it is better to avoid *current* term in site url. We can show the latest docs by default.
I think it is better to avoid '**current**' term in site url. We can show the latest docs by default.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67602
-----------------------------------------------------------
On Jan. 10, 2015, 8:44 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67602
-----------------------------------------------------------
tools/scripts/generate-site-public.sh
<https://reviews.apache.org/r/29792/#comment111654>
We need to check if svnpudsub publishes site from publish directory ot publish/current. I think it is publish. We need to change it to show current and provide links to versioned documentation - can be done in separate jira
tools/scripts/generate-site-public.sh
<https://reviews.apache.org/r/29792/#comment111653>
We should put back this cd and ready to commit messages. They were helpful
- Amareshwari Sriramadasu
On Jan. 10, 2015, 8:44 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67588
-----------------------------------------------------------
Ship it!
Looks OK to me, we will have to verify by actually doing a push.
- Jaideep dhok
On Jan. 10, 2015, 8:44 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review69130
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 14, 2015, 3:08 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 3:08 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/
-----------------------------------------------------------
(Updated Jan. 14, 2015, 3:08 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Fixed review comments
Bugs: LENS-172
https://issues.apache.org/jira/browse/LENS-172
Repository: lens
Description
-------
Right now, RestAPI documentation link is not working. It is giving the following error:
HTTP ERROR 404
Problem accessing /rest.html. Reason:
NOT_FOUND
There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
cp -r $REST_DIR/* .
Diffs (updated)
-----
src/site/apt/user/rest.apt a71f56a
tools/scripts/generate-site-public.sh 448962d
Diff: https://reviews.apache.org/r/29792/diff/
Testing
-------
Vallidated on local machine by publishing the site to local filesystem location.
Thanks,
Raju Bairishetti
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/
-----------------------------------------------------------
(Updated Jan. 10, 2015, 8:44 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-172
https://issues.apache.org/jira/browse/LENS-172
Repository: lens
Description
-------
Right now, RestAPI documentation link is not working. It is giving the following error:
HTTP ERROR 404
Problem accessing /rest.html. Reason:
NOT_FOUND
There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
cp -r $REST_DIR/* .
Diffs (updated)
-----
src/site/apt/user/rest.apt a71f56a
tools/scripts/generate-site-public.sh 448962d
Diff: https://reviews.apache.org/r/29792/diff/
Testing
-------
Vallidated on local machine by publishing the site to local filesystem location.
Thanks,
Raju Bairishetti
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Jaideep dhok <ja...@inmobi.com>.
> On Jan. 10, 2015, 8:37 a.m., Jaideep dhok wrote:
> > tools/scripts/generate-site-public.sh, line 63
> > <https://reviews.apache.org/r/29792/diff/1/?file=816013#file816013line63>
> >
> > Change error message to "unable to copy REST to current" in both lines.
I meant "copy REST to current" and "REST to $version"
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67584
-----------------------------------------------------------
On Jan. 10, 2015, 7:58 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 7:58 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 29792: LENS-172: Fix and cleanup generate site
script
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29792/#review67584
-----------------------------------------------------------
tools/scripts/generate-site-public.sh
<https://reviews.apache.org/r/29792/#comment111629>
Change error message to "unable to copy REST to current" in both lines.
- Jaideep dhok
On Jan. 10, 2015, 7:58 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29792/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 7:58 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-172
> https://issues.apache.org/jira/browse/LENS-172
>
>
> Repository: lens
>
>
> Description
> -------
>
> Right now, RestAPI documentation link is not working. It is giving the following error:
> HTTP ERROR 404
>
> Problem accessing /rest.html. Reason:
>
> NOT_FOUND
>
> There is a bug in the generate-site script. It's not copying REST dir to current/* and versions/$VERSION
> cp -r $REST_DIR/* .
>
>
> Diffs
> -----
>
> src/site/apt/user/rest.apt a71f56a
> tools/scripts/generate-site-public.sh 448962d
>
> Diff: https://reviews.apache.org/r/29792/diff/
>
>
> Testing
> -------
>
> Vallidated on local machine by publishing the site to local filesystem location.
>
>
> Thanks,
>
> Raju Bairishetti
>
>