You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/15 17:29:58 UTC
[GitHub] [spark] hvanhovell commented on a diff in pull request #38243: [SPARK-40534][CONNECT][FOLLOW-UP] Support all join types in python client
hvanhovell commented on code in PR #38243:
URL: https://github.com/apache/spark/pull/38243#discussion_r996333637
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -368,21 +368,45 @@ def __init__(
left: Optional["LogicalPlan"],
right: "LogicalPlan",
on: "ColumnOrString",
- how: proto.Join.JoinType.ValueType = proto.Join.JoinType.JOIN_TYPE_INNER,
+ how: Optional[str],
) -> None:
super().__init__(left)
self.left = cast(LogicalPlan, left)
self.right = right
self.on = on
if how is None:
- how = proto.Join.JoinType.JOIN_TYPE_INNER
- self.how = how
+ join_type = proto.Join.JoinType.JOIN_TYPE_INNER
+ elif how == "inner":
+ join_type = proto.Join.JoinType.JOIN_TYPE_INNER
+ elif how in ["outer", "full", "fullouter"]:
+ join_type = proto.Join.JoinType.JOIN_TYPE_FULL_OUTER
+ elif how in ["leftouter", "left"]:
+ join_type = proto.Join.JoinType.JOIN_TYPE_LEFT_OUTER
+ elif how in ["rightouter", "right"]:
+ join_type = proto.Join.JoinType.JOIN_TYPE_RIGHT_OUTER
+ elif how in ["leftsemi", "semi"]:
+ join_type = proto.Join.JoinType.JOIN_TYPE_LEFT_SEMI
+ elif how in ["leftanti", "anti"]:
+ join_type = proto.Join.JoinType.JOIN_TYPE_LEFT_ANTI
+ else:
Review Comment:
Why is that? Please keep in mind that these type of decisions increase the pain of porting a pyspark job over to connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org