You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/22 12:44:25 UTC

[GitHub] [geode] jvarenina commented on a diff in pull request #7378: GEODE-10056: Improve gateway-receiver load balance

jvarenina commented on code in PR #7378:
URL: https://github.com/apache/geode/pull/7378#discussion_r856192637


##########
geode-core/src/test/java/org/apache/geode/distributed/internal/LocatorLoadSnapshotJUnitTest.java:
##########
@@ -631,28 +633,93 @@ public void testFindBestServersCalledWithNegativeCount() {
   }
 
   @Test

Review Comment:
   Hi @pivotal-jbarrett , thanks for the review. Upgrading this test to JUnit 5 would be tricky because it uses @Rule annotation, which is replaced by @ExtendWith annotation. It would be necessary to implement the new interfaces (AfterEachCallback and BeforeEachCallback) to GfshCommandRule and ClusterStartupRule classes. I think that this should be a part of a separate ticket since this is not just a minor adjustment. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org