You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2014/04/25 01:06:12 UTC
Review Request 20694: Patch for KAFKA-1392
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20694/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1392
https://issues.apache.org/jira/browse/KAFKA-1392
Repository: kafka
Description
-------
Jun's v2 patch
Diffs
-----
core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
core/src/test/scala/unit/kafka/producer/ProducerTest.scala dc6a5ea4abcdff370f3b61c774bbde4e4157f412
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
Diff: https://reviews.apache.org/r/20694/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 20694: Patch for KAFKA-1392
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20694/#review41418
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On April 24, 2014, 11:06 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20694/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 11:06 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1392
> https://issues.apache.org/jira/browse/KAFKA-1392
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Jun's v2 patch
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/admin/AdminTest.scala 3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 6d489adcb307d4bffc5d36ff65ff1b16f474d4e4
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala dc6a5ea4abcdff370f3b61c774bbde4e4157f412
> core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe
> core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 3fb08e69446aba2363255d9853a02c455ac46e11
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>