[GitHub] michellethomas commented on a change in pull request #5693: Adding simple Cypress tests

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #5693: Adding simple Cypress tests
URL: https://github.com/apache/incubator-superset/pull/5693#discussion_r211804817
 
 

 ##########
 File path: superset/assets/cypress/integration/dashboard/dashboard_tests.js
 ##########
 @@ -0,0 +1,26 @@
+describe('Load dashboard', function () {
+  it('Load birth names dashboard', function () {
+    cy.server();
+    cy.login();
+
+    cy.visit('/superset/dashboard/births');
+
+    cy.route('POST', '/superset/explore_json/**').as('getJson');
+    cy.wait(6000, ['@getJson']);
 
 Review comment:
   Setting a specific time to wait is usually not necessary, but there's currently an open issue to better handle multiple matched responses. For now this is the workaround: https://github.com/cypress-io/cypress/issues/477

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org