[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2886: ARTEMIS-2541 Improve message browser of Admin UI

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2886: ARTEMIS-2541 Improve message browser of Admin UI
URL: https://github.com/apache/activemq-artemis/pull/2886#discussion_r343858514
 
 

 ##########
 File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/browse.js
 ##########
 @@ -26,44 +26,55 @@ var ARTEMIS = (function(ARTEMIS) {
          displayName: 'Message ID',
          cellTemplate: '<div class="ngCellText"><a ng-click="openMessageDialog(row)">{{row.entity.messageID}}</a></div>',
          // for ng-grid
-         width: '10%'
-      }, {
-         field: 'userID',
-         displayName: 'User ID',
-         width: '10%'
+         width: '100px'
       }, {
          field: 'type',
          displayName: 'Type',
-         width: '10%'
+         cellTemplate: '<div class="ngCellText" title="{{row.entity.type}}">{{formatType(row.entity.type)}}</div>',
+         width: '90px'
       }, {
          field: 'durable',
          displayName: 'Durable',
-         width: '10%'
+         width: '70px'
       }, {
          field: 'priority',
          displayName: 'Priority',
-         width: '7%'
+         width: '70px'
       }, {
          field: 'timestamp',
          displayName: 'Timestamp',
-         width: '19%'
+         cellTemplate: '<div class="ngCellText" title="{{row.entity.timestamp}}">{{formatTimestamp(row.entity.timestamp)}}</div>',
+         width: '160px'
       }, {
          field: 'expiration',
          displayName: 'Expires',
-         width: '10%'
+         cellTemplate: '<div class="ngCellText" title="{{row.entity.expiration}}">{{formatExpires(row.entity.expiration)}}</div>',
+         width: '180px'
       }, {
          field: 'redelivered',
          displayName: 'Redelivered',
-         width: '10%'
+         width: '100px'
       }, {
          field: 'largeMessage',
          displayName: 'Large',
-         width: '10%'
+         width: '50px'
+      }, {
+         field: 'persistentSize',
+         displayName: 'Size',
+         cellTemplate: '<div class="ngCellText" title="{{row.entity.persistentSize}}">{{formatPersistentSize(row.entity.persistentSize)}}</div>',
+         width: '100px'
+      }, {
+         field: 'userID',
+         displayName: 'User ID',
+         cellTemplate: '<div class="ngCellText">{{row.entity.userID ? row.entity.userID : row.entity.StringProperties._AMQ_VALIDATED_USER}}</div>',
 
 Review comment:
   thanks.. I didnt realize that.. thakns

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services