You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/08 16:03:30 UTC

[GitHub] [pulsar] sursingh commented on a change in pull request #10862: [Issue 10860][pulsar-metadata] Ensure metadata cache consistency across brokers

sursingh commented on a change in pull request #10862:
URL: https://github.com/apache/pulsar/pull/10862#discussion_r647586105



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
##########
@@ -229,7 +240,11 @@ public MetadataCacheImpl(MetadataStore store, MetadataSerde<T> serde) {
         return store.delete(path, Optional.empty())
                 .thenAccept(v -> {
                     // Mark in the cache that the object was removed
-                    objCache.put(path, FutureUtils.value(Optional.empty()));
+                    // objCache.put(path, FutureUtils.value(Optional.empty()));

Review comment:
       Yes the cache gets invalidated on delete. I will remove the commented line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org