Re: [PR] [AMORO-3671][Improvement]: Optimizing Allocation and Schedule Priority of Optimizer resource for Tables [amoro]

["zhoujinsong (via GitHub)" <gi...@apache.org>]

zhoujinsong commented on code in PR #3669:
URL: https://github.com/apache/amoro/pull/3669#discussion_r2239215342


##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -392,6 +392,12 @@ public class AmoroManagementConf {
           .defaultValue(Duration.ofSeconds(3))
           .withDescription("Optimizer polling task timeout.");
 
+  public static final ConfigOption<Boolean> OPTIMIZER_OVER_QUOTA_ENABLED =
+      ConfigOptions.key("optimizer.over-quota-enabled")

Review Comment:
   `self-optimizing.break-quota-limit-enabled` maybe a proper name.
   The configuration is about self-optimizing process rather than the optimizer.



##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -392,6 +392,12 @@ public class AmoroManagementConf {
           .defaultValue(Duration.ofSeconds(3))
           .withDescription("Optimizer polling task timeout.");
 
+  public static final ConfigOption<Boolean> OPTIMIZER_OVER_QUOTA_ENABLED =
+      ConfigOptions.key("optimizer.over-quota-enabled")
+          .booleanType()
+          .defaultValue(true)
+          .withDescription("Enable tables use optimizer over quota.");

Review Comment:
   ```suggestion
             .withDescription("Allow the table to break the quota limit when the resource is sufficient");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org