You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2015/01/14 02:02:17 UTC

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/307

    Remove dup code fromRemoteExecutor#executePlan method

    Remove dup code by delegating call from RemoteExecutor#executePlan to RemoteExecutor#executePlanWithJars.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink reduce_dup_code_in_executePlan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit a98f3b6d851f85201212e7efed120d6bab43e6b6
Author: Henry Saputra <he...@gmail.com>
Date:   2015-01-14T01:00:50Z

    Remove dup code by delegating call from RemoteExecutor#executePlan to RemoteExecutor#executePlanWithJars.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/307#issuecomment-69967981
  
    This change looks good to be merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

Posted by hsaputra <gi...@git.apache.org>.

Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/307#issuecomment-69969896
  
    Thanks @StephanEwen, will merge to master EOD if no one beats me to it. 
    Don't think this is needed to be in 0.8.x branch for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---