You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:12:18 UTC

[GitHub] [arrow] pitrou commented on pull request #7939: ARROW-9698: [C++] Remove -DNDEBUG flag leak in .pc file

pitrou commented on pull request #7939:
URL: https://github.com/apache/arrow/pull/7939#issuecomment-672714872


   I disagree with these changes. There no is reason to rename NDEBUG to another symbol. We should simply ensure when the ABI is the same with and without NDEBUG.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org