You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brian Fox (JIRA)" <ji...@codehaus.org> on 2008/02/09 23:46:28 UTC

[jira] Created: (MNG-3395) Default core plugin versions in the superpom.

Default core plugin versions in the superpom.
---------------------------------------------

                 Key: MNG-3395
                 URL: http://jira.codehaus.org/browse/MNG-3395
             Project: Maven 2
          Issue Type: Improvement
          Components: Artifacts and Repositories
    Affects Versions: 2.0.8
            Reporter: Brian Fox
             Fix For: 2.0.9


We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.

See here for more info.
http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Work started: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MNG-3395 started by Brian Fox.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125527 ] 

Paul Benedict commented on MNG-3395:
------------------------------------

Brian, when this is complete, please update the documentation to publicly reveal the versions. The information would probably be most appropriate as a table in the release notes page.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126583 ] 

Brian Fox commented on MNG-3395:
--------------------------------

Thanks for reviewing. I overlooked release,clean and plugin. The enforcer is going to change soon and it's about best practices, this one shouldn't be locked down (if they are using it, they should know to lock it). 

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox updated MNG-3395:
---------------------------

         Assignee: Brian Fox
    Fix Version/s: 2.0.9

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann reopened MNG-3395:
------------------------------------


bq. I overlooked release,clean and plugin
Your recent commit [r637973|http://svn.apache.org/viewvc?view=rev&revision=637973] only included version updates for exising plugins and reordering of resources-plugin. Still missing are clean-, plugin- and release-plugin. From your previous comment, I deduce this is not intended, isn't it?

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch, default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126635 ] 

Paul Benedict commented on MNG-3395:
------------------------------------

Brian, you were right about resources plugin. I missed it because it wasn't in alphabetical order.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox closed MNG-3395.
--------------------------

    Resolution: Fixed

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126627 ] 

Brian Fox commented on MNG-3395:
--------------------------------

Resources is in there, or it should be. IMO, archetype is evolving too quickly to lock it down. Since it is primarily used from the command line, this won't hurt repeatability of builds. Locking down help doesn't seem to provide any benefit either.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MNG-3395:
-----------------------------------

    Attachment: default-plugin-versions.patch

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch, default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127547 ] 

Benjamin Bentmann commented on MNG-3395:
----------------------------------------

bq. My goal isn't to lock everything down
Sure you shouldn't lock down all existing plugins, but please do this for all plugins that have bindings to the various build packagings. The packaging "maven-plugin" uses maven-plugin-plugin and hence should be locked down. Likewise, maven-clean-plugin is automatically bound and should have a default version in the super POM for the novice users to get build reproducibility.

bq. What's the benefit to locking down clean?
You could have also questioned "What's the benefit to locking down build plugin XYZ?" and the answer would be the same: a reproducible build. Reproducibility also includes the little aspect of stability. If clean-plugin-X works but clean-plugin-Y fails the build, this is not reproducible. Just to be clear: I don't want to upset anybody but please let's be honest, the implication "version X worked so version Y will work, too" is just utopie. This in mind, please consider that clean is executed by the release-plugin.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch, default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127546 ] 

Paul Benedict commented on MNG-3395:
------------------------------------

Clean can really affect builds. Especially because Windows holds locks on directories that are "opened" in other processes. The latest version of the clean plugin can deal with this.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch, default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MNG-3395:
-----------------------------------

    Attachment: default-plugin-versions.patch

bq. initial revision committed.
The maven-clean-plugin and the maven-plugin-plugin are definitively missing since these are employed by the default lifecycle bindings. If the plugin tools get out in time, the maven-plugin-plugin could be updated to 2.4 then.

The maven-enforcer-plugin and the maven-release-plugin might be added as well given their popularity.

Not addressed by the patch:
Was the plugin list meant to be sorted alphabetically? Currently, install-plugin listed after javadoc-plugin and resources-plugin listed after surefire-plugin.

Certain lines have trailing whitespace that could be removed, e.g. search for "plugin> ".

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox closed MNG-3395.
--------------------------

    Resolution: Fixed

I'm not really sure if plugin is required but I added it. Thanks for pointing out release...missed it again. What's the benefit to locking down clean? My goal isn't to lock everything down, just the stuff that really affects builds.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch, default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126624 ] 

Paul Benedict commented on MNG-3395:
------------------------------------

I'd also like to see added:
maven-archetype-plugin
maven-resources-plugin
maven-help-plugin


> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>         Attachments: default-plugin-versions.patch
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3395) Default core plugin versions in the superpom.

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126509 ] 

Brian Fox commented on MNG-3395:
--------------------------------

initial revision committed. Waiting for javadoc release before making this final.

> Default core plugin versions in the superpom.
> ---------------------------------------------
>
>                 Key: MNG-3395
>                 URL: http://jira.codehaus.org/browse/MNG-3395
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0.8
>            Reporter: Brian Fox
>            Assignee: Brian Fox
>             Fix For: 2.0.9
>
>
> We should define the plugin versions for core and other common plugins (the apache plugins is a good place to start) in the super pom in 2.0.x to help with stability.
> See here for more info.
> http://www.nabble.com/Plugin-Versions-in-the-Super-pom-to15367074s177.html#a15367074

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira