You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 19:42:52 UTC

svn commit: r1181933 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java

Author: nspiegelberg
Date: Tue Oct 11 17:42:51 2011
New Revision: 1181933

URL: http://svn.apache.org/viewvc?rev=1181933&view=rev
Log:
Fix HBCK parallelism

Summary:
After committing HBASE-3620, Ted Yu noted that we might not be
setting up our thread pool properly and actually running with just one
thread.  Tried making his modification when we experienced HBCK latency
problems & this significantly sped up processing time.

Test Plan:  - bin/hbase hbck  # on prod cluster
Reviewed By: kannan
Reviewers: kannan
CC: kannan, hbase@lists
Differential Revision: 304603
Task ID: 510832

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java?rev=1181933&r1=1181932&r2=1181933&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java Tue Oct 11 17:42:51 2011
@@ -119,9 +119,10 @@ public class HBaseFsck {
     connection = admin.getConnection();
 
     numThreads = conf.getInt("hbasefsck.numthreads", numThreads);
-    executor = new ThreadPoolExecutor(0, numThreads,
+    executor = new ThreadPoolExecutor(numThreads, numThreads,
           THREADS_KEEP_ALIVE_SECONDS, TimeUnit.SECONDS,
           new LinkedBlockingQueue<Runnable>());
+    executor.allowCoreThreadTimeOut(true);
   }
 
   public TreeMap<String, HbckInfo> getRegionInfo() {