You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Radu Cotescu (Jira)" <ji...@apache.org> on 2023/04/03 10:51:00 UTC

[jira] [Updated] (SLING-9083) Add support for authenticated requests when checking a release's build status

     [ https://issues.apache.org/jira/browse/SLING-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Radu Cotescu updated SLING-9083:
--------------------------------
    Fix Version/s: Committer CLI 1.0.2
                       (was: Committer CLI 1.0.0)

> Add support for authenticated requests when checking a release's build status
> -----------------------------------------------------------------------------
>
>                 Key: SLING-9083
>                 URL: https://issues.apache.org/jira/browse/SLING-9083
>             Project: Sling
>          Issue Type: Improvement
>          Components: Tooling
>            Reporter: Radu Cotescu
>            Priority: Major
>             Fix For: Committer CLI 1.0.2
>
>
> The {{org.apache.sling.cli.impl.ci.CIStatusValidator}} checks if a release's build status is valid, when verifying a release. Depending on the network from which the requests originate, GitHub might enforce its API rate limiting, leading to a failure in the validator - the {{success}} JSON key is missing from the response. On one hand, the validator's JSON parsing could be improved to not fail if this key is missing. However, if a request is authenticated (usually with a GitHub access token), the rate limiting is not enforced (or better said the limit is so high that it should not be reached).
> This issue should implement both suggestions from above:
> # make the JSON parsing more resilient
> # optionally use a GitHub access token, if provided in the environment, to perform authenticated requests against the GitHub API



--
This message was sent by Atlassian Jira
(v8.20.10#820010)