You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/04/05 19:58:19 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #526: [YUNIKORN-1679] Re-write event storage from map to ringbuffer
pbacsko opened a new pull request, #526:
URL: https://github.com/apache/yunikorn-core/pull/526
### What is this PR for?
Replace the map to a ring buffer data structure inside `defaultEventStore` so we don't lose events that belong to the same ObjectID.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1679
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #526: [YUNIKORN-1679] Re-write event storage from map to ringbuffer
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #526:
URL: https://github.com/apache/yunikorn-core/pull/526#issuecomment-1498053669
## [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/526?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#526](https://codecov.io/gh/apache/yunikorn-core/pull/526?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec612c7) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/1d3709b39191efb85f92586b3222500a04ffbaec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d3709b) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 74.93% 74.97% +0.03%
==========================================
Files 70 71 +1
Lines 11292 11309 +17
==========================================
+ Hits 8462 8479 +17
Misses 2531 2531
Partials 299 299
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/events/event\_ringbuffer.go](https://codecov.io/gh/apache/yunikorn-core/pull/526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9yaW5nYnVmZmVyLmdv) | `100.00% <100.00%> (ø)` | |
| [pkg/events/event\_store.go](https://codecov.io/gh/apache/yunikorn-core/pull/526?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2V2ZW50cy9ldmVudF9zdG9yZS5nbw==) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #526: [YUNIKORN-1679] Re-write event storage from map to slice
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #526: [YUNIKORN-1679] Re-write event storage from map to slice
URL: https://github.com/apache/yunikorn-core/pull/526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #526: [YUNIKORN-1679] Re-write event storage from map to ringbuffer
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #526:
URL: https://github.com/apache/yunikorn-core/pull/526#issuecomment-1498587612
Current solution is complicated. Will rewrite a simpler data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org