Re: [PR] kie-issues#1285: Remove unnecessary base image from quarkus examples (quay.io/kiegroup/kogito-runtime-jvm:latest) [incubator-kie-tools]

["tiagobento (via GitHub)" <gi...@apache.org>]

tiagobento commented on code in PR #2457:
URL: https://github.com/apache/incubator-kie-tools/pull/2457#discussion_r1662948136


##########
packages/sonataflow-operator/bddframework/pkg/framework/util.go:
##########
@@ -292,7 +292,11 @@ func AppendImageDefaultValues(image *api.Image) {
 	}
 
 	if len(image.Tag) == 0 {
-		image.Tag = GetKogitoImageVersion(version.GetTagVersion())
+		if image.Name == defaultRuntimeJVM {
+			image.Tag = GetKogitoImageVersion(version.GetOpenJDKImageVersion())
+		} else {
+			image.Tag = GetKogitoImageVersion(version.GetTagVersion())
+		}

Review Comment:
   `defaultRuntimeJVM` is a constant, so the `else` branch of this `if` statement is basically dead code...



##########
packages/sonataflow-operator/version/version.go:
##########
@@ -33,8 +33,15 @@ const (
 	tagVersion = "main"
 	// Kogito images tag version. Used for data-index and jobs-service images.
 	kogitoImagesTagVersion = "999-20240623"
+	// OpenJDK image version
+	openJDKImageVersion = "1.20"
 )
 
+// GetOpenJDKImageVersion gets the current OpenJDK image version.
+func GetOpenJDKImageVersion() string {

Review Comment:
   ```suggestion
   func GetOpenJDKImageTagVersion() string {
   ```



##########
packages/sonataflow-operator/version/version.go:
##########
@@ -33,8 +33,15 @@ const (
 	tagVersion = "main"
 	// Kogito images tag version. Used for data-index and jobs-service images.
 	kogitoImagesTagVersion = "999-20240623"
+	// OpenJDK image version
+	openJDKImageVersion = "1.20"

Review Comment:
   ```suggestion
   	openJDKImageTagVersion = "1.20"
   ```
   
   I learned from @ricardozanini that `tag` is the entire thing, like `docker.io/apache/something:1.1.1`. In this case, tagVersion would be `1.1.1`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org