[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #14798: Adjust `SHOW` statement

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #14798:
URL: https://github.com/apache/shardingsphere/pull/14798#discussion_r785431760



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -33,31 +33,7 @@ explain
     | explainType? (explainableStatement | FOR CONNECTION connectionId)
     | ANALYZE (FORMAT EQ_ TREE)? select)
     ;
-
-showDatabases

Review comment:
       @totalo Why remove these parse rule?

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/BaseRule.g4
##########
@@ -667,13 +667,15 @@ wrapperName
     ;
     
 functionName
-    : identifier
-    | (owner DOT_)? identifier
+    : (owner DOT_)? identifier
     ;
-    
+
+procName

Review comment:
       What statement corresponds to the procName parsing rule?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org