You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Lev Epshteyn (JIRA)" <ji...@apache.org> on 2008/10/09 21:16:44 UTC
[jira] Created: (SHINDIG-649) Fix some whitespace issues on IE, use
gadgets.util.registerOnLoadHandler when available
Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
---------------------------------------------------------------------------------------
Key: SHINDIG-649
URL: https://issues.apache.org/jira/browse/SHINDIG-649
Project: Shindig
Issue Type: Bug
Components: Features (Javascript)
Reporter: Lev Epshteyn
Priority: Minor
Attachments: OnLoad-and-Whitespace-Fixes.patch
IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
Also added support for gadgets.util.registerOnLoadHandler() when it is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-649) Fix some whitespace issues on IE, use
gadgets.util.registerOnLoadHandler when available
Posted by "Lev Epshteyn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lev Epshteyn updated SHINDIG-649:
---------------------------------
Attachment: OnLoad-and-Whitespace-Fixes.patch
> Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> ---------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Attachments: OnLoad-and-Whitespace-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-649) OST: Fix some whitespace issues on
IE, use gadgets.util.registerOnLoadHandler when available
Posted by "Kevin Jin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Jin updated SHINDIG-649:
------------------------------
Attachment: fix-649-test.patch
testTag_input fails after the patch. It looks like an ancient feature. If we still want to support it, please fix the code. Otherwise delete the test.
Also attached a patch for testing the new code, and modified some old tests that were broken by the new code.
> OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Attachments: fix-649-test.patch, OnLoad-and-Whitespace-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
> Code review: http://codereview.appspot.com/7450
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-649) OST: Fix some whitespace issues on
IE, use gadgets.util.registerOnLoadHandler when available
Posted by "Lev Epshteyn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lev Epshteyn updated SHINDIG-649:
---------------------------------
Description:
IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
Also added support for gadgets.util.registerOnLoadHandler() when it is available.
Code review: http://codereview.appspot.com/7450
was:
IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
Also added support for gadgets.util.registerOnLoadHandler() when it is available.
Summary: OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available (was: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available)
> OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Attachments: OnLoad-and-Whitespace-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
> Code review: http://codereview.appspot.com/7450
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-649) OST: Fix some whitespace issues on
IE, use gadgets.util.registerOnLoadHandler when available
Posted by "Lev Epshteyn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lev Epshteyn updated SHINDIG-649:
---------------------------------
Attachment: Whitespace-Test-Fixes.patch
Fixes unit tests - incorporates changes in Kevin's patch.
> OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Attachments: fix-649-test.patch, OnLoad-and-Whitespace-Fixes.patch, Whitespace-Test-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
> Code review: http://codereview.appspot.com/7450
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-649) OST: Fix some whitespace issues on
IE, use gadgets.util.registerOnLoadHandler when available
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-649.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.0.x-incubating
trunk
Patch was applied.
> OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Fix For: trunk, 1.0.x-incubating
>
> Attachments: fix-649-test.patch, OnLoad-and-Whitespace-Fixes.patch, Whitespace-Test-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
> Code review: http://codereview.appspot.com/7450
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-649) OST: Fix some whitespace issues on
IE, use gadgets.util.registerOnLoadHandler when available
Posted by "Kevin Jin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639174#action_12639174 ]
Kevin Jin commented on SHINDIG-649:
-----------------------------------
The new patch Whitespace-Test-Fixes.patch replaces fix-649-test.patch -- submitter only needs to apply the new one.
It'll be better to remove _T_Conditional_Number, _T_Conditional_Number, _T_Conditional_Number, _T_Tag_input in ost_test.html, and change from double quotes (") to single quotes (') for JS strings.
> OST: Fix some whitespace issues on IE, use gadgets.util.registerOnLoadHandler when available
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-649
> URL: https://issues.apache.org/jira/browse/SHINDIG-649
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Lev Epshteyn
> Priority: Minor
> Attachments: fix-649-test.patch, OnLoad-and-Whitespace-Fixes.patch, Whitespace-Test-Fixes.patch
>
>
> IE interprets whitespace literally in calls to document.createTextNode(). Special handling existed for this before, and this patch fixes some issues with it. In particular, trailing/leading spaces will be stripped off of <os:Render/>, and whitespace between tags will now be properly detected.
> Also added support for gadgets.util.registerOnLoadHandler() when it is available.
> Code review: http://codereview.appspot.com/7450
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.