[GitHub] [spark] cloud-fan commented on a diff in pull request #37626: [SPARK-40152][SQL][TESTS] Add tests for SplitPart

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37626:
URL: https://github.com/apache/spark/pull/37626#discussion_r952639395


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala:
##########
@@ -2522,4 +2522,24 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
           Date.valueOf("2017-02-12")))
     }
   }
+
+  test("SplitPart") {

Review Comment:
   Can we simply add more tests in the existing test case `test("elementAt")`? We just need to test the `outOfBoundValue`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org