[GitHub] [incubator-livy] dockerzhang commented on a change in pull request #183: [LIVY-609] LDAP auth for Livy thriftserver

[GitBox <gi...@apache.org>]

dockerzhang commented on a change in pull request #183: [LIVY-609] LDAP auth for Livy thriftserver
URL: https://github.com/apache/incubator-livy/pull/183#discussion_r306099722
 
 

 ##########
 File path: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthenticationProvider.scala
 ##########
 @@ -72,3 +77,36 @@ class CustomAuthenticationProvider(conf: LivyConf) extends PasswdAuthenticationP
     provider.Authenticate(user, password)
   }
 }
+
+/**
+  * An implementation of [[PasswdAuthenticationProvider]] for LDAP to authenticate a user.
+  */
+class LdapAuthenticationProvider(conf: LivyConf) extends PasswdAuthenticationProvider {
+  override def Authenticate(user: String, password: String): Unit = {
+    val ldapURL = conf.get(LivyConf.THRIFT_LDAP_AUTHENTICATION_URL)
 
 Review comment:
   I will rewrite according to hive's implementation, and UTs will be added too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services