You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/06/28 15:12:42 UTC

[GitHub] [arrow] felipecrv commented on pull request #36294: GH-36293: [C++] Use ipc_write_options.memory_pool for compressed buffer and shrink after compression

felipecrv commented on PR #36294:
URL: https://github.com/apache/arrow/pull/36294#issuecomment-1611626979

   @pitrou should we avoid setting `default_memory_pool()` as a default argument value? At least in internal APIs?
   
   It bothers me that the compiler could ensure we always inject a pool, but it's easy to mistakenly use `default_memory_pool()` because it's the default argument value in so many functions and constructors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org