[GitHub] eolivelli commented on a change in pull request #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #5: [MCHECKSTYLE-353] - Don't resolve any dependencies
URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#discussion_r257583296
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
 ##########
 @@ -72,7 +72,7 @@
  * @author <a href="mailto:joakim@erdfelt.net">Joakim Erdfelt</a>
  * @version $Id$
  */
-@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST,
+@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.NONE,
 
 Review comment:
   I think a good comprimise would be to switch to "COMPILE" and not to "NONE"
   
   This way we will save resources (The case in MCHECKSTYLE-353 is about test dependencies ?) and it will save the case in which you are bundling checkstyle configuration on the classpath
   
   Does this solution work for you @zregvart  ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services