[GitHub] [superset] dpgaspar commented on a diff in pull request #20892: feat: Add dataset tagging to the back-end

[GitBox <gi...@apache.org>]

dpgaspar commented on code in PR #20892:
URL: https://github.com/apache/superset/pull/20892#discussion_r977351949


##########
superset/migrations/versions/2018-07-26_11-10_c82ee8a39623_add_implicit_tags.py:
##########
@@ -33,7 +33,7 @@
 from sqlalchemy import Column, DateTime, Enum, ForeignKey, Integer, String
 from sqlalchemy.ext.declarative import declarative_base, declared_attr
 
-from superset.models.tags import ObjectTypes, TagTypes
+from superset.tags.models import ObjectTypes, TagTypes

Review Comment:
   not related with this PR, but ideally we should place the Enums here also, to avoid this problem for example and move away from native Enums on the DB in favour of strings (if an Enum changes no new db migration is needed)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org