You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "TheR1sing3un (via GitHub)" <gi...@apache.org> on 2025/01/13 13:25:33 UTC
[PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
TheR1sing3un opened a new pull request, #12627:
URL: https://github.com/apache/hudi/pull/12627
In NBCC mode, the file id of each bucket should be fixed, and we should follow the generation rules everywhere to avoid having different file ids in the same bucket.
### Change Logs
1. fix the generation of uncertain file id in NBCC mode
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
none
### Risk level (write none, low medium or high below)
low
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
none
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [x] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1914009026
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBucketIndexPartitioner.java:
##########
@@ -127,10 +131,13 @@ public BucketInfo getBucketInfo(int bucketNumber) {
if (fileIdOption.isPresent()) {
return new BucketInfo(BucketType.UPDATE, fileIdOption.get(), partitionPath);
} else {
- // Always write into log file instead of base file if using NB-CC
- BucketType bucketType = isNonBlockingConcurrencyControl ? BucketType.UPDATE : BucketType.INSERT;
String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(bucketId, isNonBlockingConcurrencyControl);
- return new BucketInfo(bucketType, fileIdPrefix, partitionPath);
+ // Always write into log file instead of base file if using NB-CC
+ if (isNonBlockingConcurrencyControl) {
+ String fileId = FSUtils.createNewFileId(fileIdPrefix, 0);
Review Comment:
Can you make sure whether Flink writer has the 0 as suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587532513
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591556537
If I do not unify the naming rule on spark first, problems will occur in the following scenarios: nsert and then bulk_insert. In this case, file naming will be disorderly, and one bucket generates two file ids:
<img width="1096" alt="image" src="https://github.com/user-attachments/assets/069fb234-5c84-41fa-b3c6-52b91a3c3b19" />
<img width="780" alt="image" src="https://github.com/user-attachments/assets/858e2622-ae45-488d-8a05-ca4ccf56ec54" />
@danny0405 How about we unify the spark side with this pr first, and then unify spark/flink in the next Pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592206639
We should unify the generation in this PR, otherwise the code is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2594444893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
}, {
"hash" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2884",
"triggerID" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8cbb950fe32ae4544a03358973698d9e944b166a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2884)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587102072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591796108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1917832325
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -115,6 +115,13 @@ private static String newBucketFileIdFixedSuffix(int bucketId) {
return newBucketFileIdFixedSuffix(bucketIdStr(bucketId));
}
+ /**
+ * Generate a new file id for NBCC mode, file id is fixed for each bucket with format: "{bucket_id}-0000-0000-0000-000000000000-0"
+ */
+ public static String newBucketFileIdForNBCC(int bucketId) {
+ return FSUtils.createNewFileId(newBucketFileIdFixedSuffix(bucketId), 0);
Review Comment:
Is the change compatible with existing behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591704145
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823)
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591824779
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592798277
> We should unify the generation in this PR, otherwise the code is broken.
Done, I unify it with format: `{bucket_id}-0000-0000-0000-000000000000-0` in both Spark and Flink.
Now we can perform both stream mode and batch mode writes concurrently without data duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587106703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587317159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2594359867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
}, {
"hash" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e723649df38186802ab881d0ee482d0e5f90a27f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871)
* 8cbb950fe32ae4544a03358973698d9e944b166a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1917834038
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -115,6 +115,13 @@ private static String newBucketFileIdFixedSuffix(int bucketId) {
return newBucketFileIdFixedSuffix(bucketIdStr(bucketId));
}
+ /**
+ * Generate a new file id for NBCC mode, file id is fixed for each bucket with format: "{bucket_id}-0000-0000-0000-000000000000-0"
+ */
+ public static String newBucketFileIdForNBCC(int bucketId) {
+ return FSUtils.createNewFileId(newBucketFileIdFixedSuffix(bucketId), 0);
Review Comment:
> Is the change compatible with existing behavior?
The bucket with existing data will be written with the existing file name. Only the newly added bucket will use the new name, which does not cause compatibility problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592802519
In NBCC mode, changing the file naming format does not affect the historical files, because when the file of a bucket already exists, it will continue to write according to the existing file name. When the bucket does not have existing files, the file id will be generated using the current unified naming format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591702208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823)
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1914123666
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBucketIndexPartitioner.java:
##########
@@ -127,10 +131,13 @@ public BucketInfo getBucketInfo(int bucketNumber) {
if (fileIdOption.isPresent()) {
return new BucketInfo(BucketType.UPDATE, fileIdOption.get(), partitionPath);
} else {
- // Always write into log file instead of base file if using NB-CC
- BucketType bucketType = isNonBlockingConcurrencyControl ? BucketType.UPDATE : BucketType.INSERT;
String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(bucketId, isNonBlockingConcurrencyControl);
- return new BucketInfo(bucketType, fileIdPrefix, partitionPath);
+ // Always write into log file instead of base file if using NB-CC
+ if (isNonBlockingConcurrencyControl) {
+ String fileId = FSUtils.createNewFileId(fileIdPrefix, 0);
Review Comment:
> Can you make sure whether Flink writer has the 0 as suffix.
Yes, I am sorry that I did not notice the rules on flink side at the beginning, I just checked it, it seems that there will be no `-0` suffix when writing on flink side, I think we should ignore the specific engine, and completely fix the file id generation rules of NBCC, so that we don't have a problem if we process stream writes and batch writes together.
In my next pr, I will comb and unify the file id rules for all in NBCC mode, and add more test to verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592004203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on code in PR #12627:
URL: https://github.com/apache/hudi/pull/12627#discussion_r1914123666
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBucketIndexPartitioner.java:
##########
@@ -127,10 +131,13 @@ public BucketInfo getBucketInfo(int bucketNumber) {
if (fileIdOption.isPresent()) {
return new BucketInfo(BucketType.UPDATE, fileIdOption.get(), partitionPath);
} else {
- // Always write into log file instead of base file if using NB-CC
- BucketType bucketType = isNonBlockingConcurrencyControl ? BucketType.UPDATE : BucketType.INSERT;
String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(bucketId, isNonBlockingConcurrencyControl);
- return new BucketInfo(bucketType, fileIdPrefix, partitionPath);
+ // Always write into log file instead of base file if using NB-CC
+ if (isNonBlockingConcurrencyControl) {
+ String fileId = FSUtils.createNewFileId(fileIdPrefix, 0);
Review Comment:
> Can you make sure whether Flink writer has the 0 as suffix.
I am sorry that I did not notice the rules on flink side at the beginning, I just checked it, it seems that there will be no `-0` suffix when writing on flink side, I think we should ignore the specific engine, and completely fix the file id generation rules of NBCC, so that we don't have a problem if we process stream writes and batch writes together.
In my next pr, I will comb and unify the file id rules for all in NBCC mode, and add more test to verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587532858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592796544
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865)
* e723649df38186802ab881d0ee482d0e5f90a27f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #12627:
URL: https://github.com/apache/hudi/pull/12627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2587720655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 07d6143bb9ccad78030c9e554b8658d2f2c5ef24 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592793603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53c2be2447c07b3db0fb68cf5a5d72166e729ce3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860) Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865)
* e723649df38186802ab881d0ee482d0e5f90a27f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2594361106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
}, {
"hash" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2884",
"triggerID" : "8cbb950fe32ae4544a03358973698d9e944b166a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e723649df38186802ab881d0ee482d0e5f90a27f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871)
* 8cbb950fe32ae4544a03358973698d9e944b166a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2884)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Fix the generation of uncertain file id in NBCC mode [hudi]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2591823176
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8866] Unified the file naming rules in NBCC mode [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12627:
URL: https://github.com/apache/hudi/pull/12627#issuecomment-2592979827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2821",
"triggerID" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"triggerType" : "PUSH"
}, {
"hash" : "07d6143bb9ccad78030c9e554b8658d2f2c5ef24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2823",
"triggerID" : "2587532513",
"triggerType" : "MANUAL"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2860",
"triggerID" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"triggerType" : "PUSH"
}, {
"hash" : "53c2be2447c07b3db0fb68cf5a5d72166e729ce3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2865",
"triggerID" : "2591823176",
"triggerType" : "MANUAL"
}, {
"hash" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871",
"triggerID" : "e723649df38186802ab881d0ee482d0e5f90a27f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e723649df38186802ab881d0ee482d0e5f90a27f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2871)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org