You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ep...@apache.org on 2005/09/12 20:02:21 UTC

svn commit: r280378 - in /maven/maven-1/plugins/trunk/simian: src/plugin-resources/simian.jsl xdocs/changes.xml

Author: epugh
Date: Mon Sep 12 11:02:15 2005
New Revision: 280378

URL: http://svn.apache.org/viewcvs?rev=280378&view=rev
Log:
MPSIMIAN-12 Simian report contains broken links

Modified:
    maven/maven-1/plugins/trunk/simian/src/plugin-resources/simian.jsl
    maven/maven-1/plugins/trunk/simian/xdocs/changes.xml

Modified: maven/maven-1/plugins/trunk/simian/src/plugin-resources/simian.jsl
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/simian/src/plugin-resources/simian.jsl?rev=280378&r1=280377&r2=280378&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/simian/src/plugin-resources/simian.jsl (original)
+++ maven/maven-1/plugins/trunk/simian/src/plugin-resources/simian.jsl Mon Sep 12 11:02:15 2005
@@ -99,7 +99,7 @@
 			<j:set var="testDirLength" value="${testDir.length() + 1}"/>
                         <j:set var="testIndex" value="${name.lastIndexOf(testDir)}"/>
                         <j:choose>
-                          <j:when test="${testIndex > 0}">
+                          <j:when test="${testIndex > -1}">
 				<j:set var="name" value="${name.substring(mavenTool.toInteger(testDirLength.toString()))}"/>
 			  </j:when>
 			  <j:otherwise>
@@ -114,21 +114,21 @@
                             <j:set var="nameWithoutJavaExtension" value="${name.substring(0, index)}"/>
                             <util:replace var="nameWithoutJavaExtension" value="${nameWithoutJavaExtension}" oldChar="\\" newChar="/"/>
 				<j:choose>
-				  <j:when test="${testIndex > 0}">
-				    <li><a href="xref/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
+				  <j:when test="${testIndex > -1}">
+				    <li><a href="xref-test/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
 				  </j:when>
 				  <j:otherwise>
-				    <li><a href="xref-test/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
+				    <li><a href="xref/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
 				  </j:otherwise>
 				</j:choose>
                           </j:when>
                           <j:otherwise>
 				<j:choose>
-				  <j:when test="${testIndex > 0}">
-	                            <li><a href="xref/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
+				  <j:when test="${testIndex > -1}">
+	                            <li><a href="xref-test/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
 				  </j:when>
 				  <j:otherwise>
-	                            <li><a href="xref-test/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
+	                            <li><a href="xref/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>
 				  </j:otherwise>
 				</j:choose>
                           </j:otherwise>

Modified: maven/maven-1/plugins/trunk/simian/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/simian/xdocs/changes.xml?rev=280378&r1=280377&r2=280378&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/simian/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/simian/xdocs/changes.xml Mon Sep 12 11:02:15 2005
@@ -25,6 +25,9 @@
     <author email="maurice@maguyane.net">Maurice Montg?nie</author>
   </properties>
   <body>
+    <release version="1.6" date="SVN">
+      <action dev="epugh" type="fix" issue="MPSIMIAN-12" due-to="James Dickinson">Simian report contains broken links to xref/xref-test directories</action>
+    </release>
     <release version="1.5" date="2005-07-11">
       <action dev="epugh" type="add" issue="MPSIMIAN-7">Add include/exclude pattern for test directories.</action>
       <action dev="benoitx" type="update" issue="MPSIMIAN-14">Upgrade to Simian 2.2.4 and XML file output from Simian.</action>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org