You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2026/06/09 08:40:49 UTC
(kafka) branch trunk updated: MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache (#22427)
This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new c09c9cd0fff MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache (#22427)
c09c9cd0fff is described below
commit c09c9cd0fff2874630beefdb11df3c4122567c80
Author: RonGamzu <37...@users.noreply.github.com>
AuthorDate: Tue Jun 9 11:40:42 2026 +0300
MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache (#22427)
Fix two minor comment/Javadoc typos found while reading the codebase:
- `CompletableEventReaperTest`: the word "amd" (should be "and")
appeared
in three identical inline comments across `testExpired`,
`testCompleted`,
and `testCompletedAndExpired`.
- `LeaderEpochFileCache`: the class-level Javadoc used "instantiater" as
an agent noun; the correct English form is "instantiator".
No logic or behaviour changes — comments and Javadoc only.
Reviewers: Ken Huang <s7...@gmail.com>, Chia-Ping Tsai
<ch...@gmail.com>
---
.../consumer/internals/events/CompletableEventReaperTest.java | 6 +++---
.../apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaperTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaperTest.java
index 6b7e1855cbd..e9e9aaf1632 100644
--- a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaperTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaperTest.java
@@ -47,7 +47,7 @@ public class CompletableEventReaperTest {
UnsubscribeEvent event = new UnsubscribeEvent(calculateDeadlineMs(time.milliseconds(), timeoutMs));
reaper.add(event);
- // Without any time passing, we check the reaper and verify that the event is not done amd is still
+ // Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event.future().isDone());
@@ -75,7 +75,7 @@ public class CompletableEventReaperTest {
UnsubscribeEvent event = new UnsubscribeEvent(calculateDeadlineMs(time.milliseconds(), timeoutMs));
reaper.add(event);
- // Without any time passing, we check the reaper and verify that the event is not done amd is still
+ // Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event.future().isDone());
@@ -106,7 +106,7 @@ public class CompletableEventReaperTest {
reaper.add(event1);
reaper.add(event2);
- // Without any time passing, we check the reaper and verify that the event is not done amd is still
+ // Without any time passing, we check the reaper and verify that the event is not done and is still
// being tracked.
assertEquals(0, reaper.reap(time.milliseconds()));
assertFalse(event1.future().isDone());
diff --git a/storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java b/storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java
index 49a97f6c0d1..fe098229f39 100644
--- a/storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java
+++ b/storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java
@@ -47,7 +47,7 @@ import static org.apache.kafka.common.requests.OffsetsForLeaderEpochResponse.UND
* Offset = offset of the first message in each epoch.
* <p>
* Note that {@link #truncateFromStartAsyncFlush},{@link #truncateFromEndAsyncFlush} flush the epoch-entry changes to checkpoint asynchronously.
- * Hence, it is instantiater's responsibility to ensure restoring the cache to the correct state after instantiating
+ * Hence, it is instantiator's responsibility to ensure restoring the cache to the correct state after instantiating
* this class from checkpoint (which might contain stale epoch entries right after instantiation).
*/
public final class LeaderEpochFileCache {